You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I'd like to try adding support for message tags. They would have to be stored in SircMessage, and I can see four ways to do it:
their own structure: typedef struct { char *key; char *value } SircMessageTag (with value NULLable if it's a tag with no value or an empty value) and SircMessage storing an array of those + a count
storing an array of key + value pair, either NULL-terminated or with a count
GHashTable
adding an attribute to SircMessage for each tag name, populated directly by the parser; and discard unknown tags
Option 3 would probably be the most convenient, but it will be an issue if you want to add support for extensions/plugins/... in the future; as they can't use tags the parser isn't aware of.
I prefer the 1st way, it also can work with 4st way: adding frequence uesed SircMessageTag to SircMessage for each tag name, for unknown tag, we adding it into an array.
Hi, I'd like to try adding support for message tags. They would have to be stored in SircMessage, and I can see four ways to do it:
typedef struct { char *key; char *value } SircMessageTag
(withvalue
NULLable if it's a tag with no value or an empty value) andSircMessage
storing an array of those + a countGHashTable
SircMessage
for each tag name, populated directly by the parser; and discard unknown tagsOption 3 would probably be the most convenient, but it will be an issue if you want to add support for extensions/plugins/... in the future; as they can't use tags the parser isn't aware of.
Ditto for
SircCommandBuilder
.What do you think?
(related issue: GH-75)
The text was updated successfully, but these errors were encountered: