Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign to upload review comments in JSON file instead of posting directly #111

Open
slarse opened this issue Jun 18, 2021 · 0 comments · May be fixed by #112
Open

Redesign to upload review comments in JSON file instead of posting directly #111

slarse opened this issue Jun 18, 2021 · 0 comments · May be fixed by #112

Comments

@slarse
Copy link
Collaborator

slarse commented Jun 18, 2021

Due to the limitations of the read-only GitHub token that's available when running a PR from a fork, it's not possible for an Action to post comments on its own. I've designed a workaround for this that revolves around uploading a JSON file as an artifact, and then have a bot post the comments on behalf of the action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Redesign review commenting as upload of JSON artifact SpoonLabs/sorald-buildbreaker
1 participant
@slarse