-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project level warnings/messages #712
Comments
I don't fully understand this. What's the intention of these warnings? |
For example, if a plugin is sending users offsite, we want to warn about that. Think the new plugin info at the top, but generalized for any warning. |
Theoretically we have an offsite filter here Ore/app/models/project/Page.scala Line 210 in 8aec09e
|
That was just one example. The point was that the reviewers wanted a system where they could apply project level info that they don't know the specifics of in advance. Also, the link out warning doesn't tell you why you're leaving the site, just that you are. It also doesn't warn you before you actually click on a link. One specific case that was brought up was a plugin linking to a dependency not on Ore. The reviewers wanted a loud and clear warning for this for example. |
As discussed on SPORE, it should be possible to define a warnings/message that's shown for project level. Needs the message table described in #707
The text was updated successfully, but these errors were encountered: