Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project level warnings/messages #712

Open
Katrix opened this issue Nov 17, 2018 · 4 comments
Open

Project level warnings/messages #712

Katrix opened this issue Nov 17, 2018 · 4 comments
Milestone

Comments

@Katrix
Copy link
Member

Katrix commented Nov 17, 2018

As discussed on SPORE, it should be possible to define a warnings/message that's shown for project level. Needs the message table described in #707

@felixoi
Copy link
Member

felixoi commented Nov 18, 2018

I don't fully understand this. What's the intention of these warnings?

@Katrix
Copy link
Member Author

Katrix commented Nov 18, 2018

For example, if a plugin is sending users offsite, we want to warn about that. Think the new plugin info at the top, but generalized for any warning.

@felixoi
Copy link
Member

felixoi commented Nov 18, 2018

Theoretically we have an offsite filter here

controllers.routes.Application.linkOut(urlString).toString
but it seems to be broken. If we fix this I don't see any usecase for this but I'm open for a discussion. All projects the user really needs to be warned about should be hidden IMO.

@Katrix
Copy link
Member Author

Katrix commented Nov 18, 2018

That was just one example. The point was that the reviewers wanted a system where they could apply project level info that they don't know the specifics of in advance. Also, the link out warning doesn't tell you why you're leaving the site, just that you are. It also doesn't warn you before you actually click on a link.

One specific case that was brought up was a plugin linking to a dependency not on Ore. The reviewers wanted a loud and clear warning for this for example.

@Katrix Katrix added this to the v1.8.x milestone Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants