Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ore localizable #546

Merged
merged 6 commits into from
Jul 27, 2018
Merged

Make Ore localizable #546

merged 6 commits into from
Jul 27, 2018

Conversation

Katrix
Copy link
Member

@Katrix Katrix commented May 18, 2018

Partially resolves #544

Ensures that there shouldn't be anything in Ore stopping us from beginning to localize it. Technically WIP because I haven't tested if it works, and auth needs changes to make the language switchable.

I took the liberty to apply the boy scouts rule as I saw fit while working on this PR.

Stuff which might not work or display correctly with other locales.

  • Stuff not entered in the messages file (Don't think there is much that falls under this one)
  • Stuff where the parameters should be passed to the messages file
  • Other things I can't think of currently

EDIT: Tested this and the basics should work

image

For now it only works if the language is set in the browser. Auth needs changes so that a user can change the language too.

To add a supported language:

  1. Add it to play.i18n.langs in the config.
  2. Create a messages. file that sits besides the messages file.

@Katrix Katrix changed the title [WIP] Make Ore localizable Make Ore localizable Jun 9, 2018
@phase phase merged commit 909d335 into SpongePowered:master Jul 27, 2018
@phase phase self-assigned this Jul 27, 2018
@Katrix Katrix deleted the feature/ore-localize branch July 27, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long term localization
3 participants