-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.0 #23
Draft
Speyedr
wants to merge
46
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an external library. Considering how many people are now using this project I don't think it's considerate to try and roll my own low-level version.
… also use WinDivert and therefore may conflict with SCBlocker.
…odules inside those processes.
…rsion from main instead of the other way round. This way, cx_Freeze is not required to run the program directly (because really it shouldn't be necessary to have a build tool if you're not building...)
…nslation is missing (instead of just throwing an exception and risking crashing the program).
Seems to be performing far slower than expected. Could be the print messages bottlenecking but the regex might also be the problem.
…t permissions (even though under normal circumstances this program should have Administrator permissions).
…linking to non-relevant issues when using the pound symbol `#` followed by a number. Also remembered to add the Dutch translation to the list of readme files that can be updated. Also re-ran the script to apply the pound-number-fix.
…ate versioning info).
Fixed certain path inconsistencies, added uac-admin flag.
…cated at some point
Need to think of a way to use the async logger to lighten the load.
…done to automatically adjust the filter settings or warn the user if this occurs.
…t host "safely" needed to be refactored a bit.
…o be both pushed to async logger In the future there should be defined "processing methods" for different types
…orse*), going to have to go back to the drawing board for this. I've noticed a couple of things which are redundant, such as: - There is no real "need" to have the process names on the initial scan. Only the Process IDs are necessary. - So, simply return the process IDs and just use that initially. - Apparently, checking if a process exists is faster than attempting to construct the Process object? - So, check if processes still exist before attempting to open them. - Alternatively, we embed process_iter() usage inside of construct_module_trie() to prevent any sort of race conditions.
…f using ctypes.windll.psapi.
…even when only querying limited information?
…the very least, this seems promising: The entire function from start to finish is almost 4x as fast! Just looking at it now, there's still several parts I can optimise out here. (Hopefully I don't need to roll my own PrefixTrie as well...)
…), I only need PROCESS_QUERY_LIMITED_INFORMATION for GetModuleFileNameExA. Funnily enough, I'd need PROCESS_QUERY_INFORMATION *and* PROCESS_VM_READ to call GetModuleFileNameExW, instead of just the single limited query info for the ANSI version. Very weird...
…e given in the code
…factored some code to allow better re-use
…the files that are *actually* used by the menus, which can be done by simply wrapping all existing strings in the Translator() constructor.
… backwards-compatibility. ...Also, apparently SCBlocker has been saving to config.ini instead of settings.ini and I never noticed???
…rate / construct the menu text for in future
…ic). I think that's all I can do tonight; my mind's starting to hit blanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a roadmap to v0.2.0, listing the intended features and bugfixes that will be present in v0.2.0
This Draft will be converted to an actual PR once all the changes have been completed, at which point the project's main branch will be updated.
Major Changes
Builds will now automatically request UAC permissions without needing to manually run the program as Administrator.
cx-Freeze
6.10 or greater (see Minor Changes)When the filter is turned ON, the program will now check if any other running processes have WinDivert loaded. If this is detected, the user will be warned that other programs using WinDivert may prevent SCBlocker from working properly.
Official releases are now personally signed by me using a Code Signing Certificate.
The program now supports dynamically loading "translation files" from a directory relative to SCBlocker.exe.
Minor / Cosmetic Changes
cx-Freeze
requirement to 6.10.x (to support auto-requesting UAC permissions)pygtrie
andpsutil
for supporting WinDivert conflict detectionpywin32
to support build stamping and versioningVERSION
variable inmain.py
(instead of being declared locally) to prevent divergence.settings.ini
.sync_readme.py
script now includes an auto-fix for a cosmetic issue with README files when using the#
symbol followed by a number. Because of GitHub's Issue Notation, GitHub automatically adds unwanted URLs to text such as#1
, which could be confusing to some people, as the links generated have no relevance to the content in the README.SOURCE
file is now present in builds to comply with this project's license. (GPLv3)tkinter
is now excluded from future builds as it is not required for this project.settings.ini
, when it's actuallyconfig.ini
.Bugfixes
prs-gta5-prod.ros.rockstargames.com
(used by DROP_CLIENT_POST filter) instead of risking an unhandled exception.Notes