Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fragility because send() is not mocked #51

Open
tonyandrewmeyer opened this issue Feb 29, 2016 · 0 comments
Open

Test fragility because send() is not mocked #51

tonyandrewmeyer opened this issue Feb 29, 2016 · 0 comments

Comments

@tonyandrewmeyer
Copy link
Contributor

This build broke, not because of the change, but because of a timing issue.

The tests don’t mock out the send() method, so there’s an assumption that the send() will take place in the same second as the expected request is constructed. That’s fragile, so it will break some times, like here.

We probably don’t want to mock send(), because that will change what the tests are testing too much. It might be simplest to mock time.time() itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants