Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin sonar-dotnet to 9.7 in old SQ ITs #1663

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Pin sonar-dotnet to 9.7 in old SQ ITs #1663

merged 2 commits into from
Aug 18, 2023

Conversation

andrei-epure-sonarsource
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource commented Aug 17, 2023 •
edited
Loading

Fix #1664

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrei-epure-sonarsource andrei-epure-sonarsource marked this pull request as ready for review August 18, 2023 08:46
@andrei-epure-sonarsource andrei-epure-sonarsource mentioned this pull request Aug 18, 2023
Merged
andrei-epure-sonarsource
andrei-epure-sonarsource commented Aug 18, 2023
View reviewed changes
azure-pipelines.yml
@@ -420,20 +420,23 @@ stages:
vs2017_latest89:
PRODUCT: "SonarQube"
SQ_VERSION: "LATEST_RELEASE[8.9]"
SONAR_DOTNET_VERSION: '9.7.0.75501' # sonar-dotnet 9.8 will mention 9.9 as minimum supported version
SONAR_CFAMILYPLUGIN_VERSION: "6.20.5.49286" # LATEST_RELEASE of CFAMILY is not compatible with old SQ
MSBUILD_PATH: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\MSBuild.exe"
JDKVERSION: "1.11"
TEST_SUITE: "**/SonarQubeTestSuite.java"
vs2019_latest79:
PRODUCT: "SonarQube"
SQ_VERSION: "LATEST_RELEASE[7.9]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this in #1662

costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit 82bb223 into master Aug 18, 2023
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the andrei/pin-sonar-dotnet-version branch August 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees

@andrei-epure-sonarsource andrei-epure-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin sonar-dotnet version in unsupported LTS SonarQube integration tests
2 participants
@andrei-epure-sonarsource @costin-zaharia-sonarsource