Code structure suggestions

[Eirenliel]

Can't write, but I can criticize! So, here are my suggestions on what to do change with code examples!

1. Move ESP-specific functions to a separate file

Nighty-Hardware-Tester/tester/src/main.rs

Line 30 in f0b7ff4

fn reset_esp_no_delay(pin: &mut OutputPin) -> rppal::gpio::Result<()> {

Nighty-Hardware-Tester/tester/src/main.rs

Line 40 in f0b7ff4

fn reset_esp(pin: &mut OutputPin) -> rppal::gpio::Result<()> {

Nighty-Hardware-Tester/tester/src/main.rs

Line 48 in f0b7ff4

fn enable_flashing(flash_pin: &mut OutputPin, rst_pin: &mut OutputPin) -> rppal::gpio::Result<()> {

2. Move serial-specific functions to a separate file

Nighty-Hardware-Tester/tester/src/main.rs

Line 78 in f0b7ff4

fn read_serial(serial: &mut Box<dyn SerialPort>) -> Result<([u8; 128], usize), String> {

3. Split main function into multiple stages, like init, runTests, generateReport, finish, etc...

Nighty-Hardware-Tester/tester/src/main.rs

Line 87 in f0b7ff4

fn main() {

4. Instead of repeating this part of code on error or on success it should be a separate function that would be easy to edit everywhere

Nighty-Hardware-Tester/tester/src/main.rs

Lines 361 to 364 in f0b7ff4

	reporter.fill(tui::Color::Red);
	sleep(Duration::from_secs(1));
	wait_for_next_board(&mut reporter, board);

Nighty-Hardware-Tester/tester/src/main.rs

Lines 711 to 714 in f0b7ff4

	reporter.fill(tui::Color::Green);
	sleep(Duration::from_secs(1));
	wait_for_next_board(&mut reporter, board);

5. We should first connect to serial, then reset the board, since USB is not reset.

Nighty-Hardware-Tester/tester/src/main.rs

Lines 424 to 426 in f0b7ff4

	reset_esp_no_delay(&mut rst_pin).unwrap();
	reporter.in_progress("Connecting to serial port...");

6. All [ERR], [FATAL], [SEVERE] etc errors in logs should be reported as test failure, not just a few specific ones

Nighty-Hardware-Tester/tester/src/main.rs

Line 500 in f0b7ff4

if l.contains("[ERR] I2C: Can't find I2C device on provided addresses, scanning for all I2C devices and returning") ||

7. Should check that BNO is on the correct address and reports correct firmware values, not just part of the log (ask for the full log)

Nighty-Hardware-Tester/tester/src/main.rs

Line 507 in f0b7ff4

if l.contains("[INFO ] [BNO080Sensor:0] Connected to") {

8. Actually serial should probably have a function to "wait for text and throw an error if it gets [ERR], [FATAL], [SEVERE]", so we could reuse it. We should be able to send it a list of strings to watch for - all of them should be present to succeed and no errors should be present during this time.

9. Figure out why serial writing doesn't work, and GET TEST is not parsed by the board at all...