Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure common static assets paths are skipping sessions #355

Open
themightychris opened this issue Nov 22, 2022 · 1 comment
Open

Ensure common static assets paths are skipping sessions #355

themightychris opened this issue Nov 22, 2022 · 1 comment
Assignees

Comments

@themightychris
Copy link
Contributor

themightychris commented Nov 22, 2022

In newrelic log data, we see that /img/**/*.png and /webapps/*/resources/** requests are loading the sessions table and being slowed down substantially when the database is thrashing. These assets are all public though with no access restrictions and should be in the Site::$skipSessionPaths list.

One potential complication here though is that /webapps/* ARE subject to access control, and the current implementation of Site::$skipSessionPaths is only capable of matching path prefixes—so it may need to be enhanced to support glob patterns

@themightychris
Copy link
Contributor Author

Did some initial investigation into this:

The best options seems to be to upgrade current php-core and legacy kernel releases to use fnmatch and then coordinate a new release or the next build of Gatekeeper to pair the new php-core version with upgraded skipSessionPaths config values

Doing a new 1.0.x release and then upgrading quarry02 would be kind of risky though, and we want to migrate that host to a modern docker-based one ASAP though, so it might make the most sense to get this prepared and then defer deployment until we migrate quarry02 to a new machine.

In the meantime, we might hotpatch quarry02—there's basically zero risk we're going to accidentally upgrade it

@acouch acouch removed the Epic label Dec 2, 2022
@acouch acouch self-assigned this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants