Skip to content
This repository has been archived by the owner on Aug 4, 2019. It is now read-only.

Update lint configurations #142

Open
themightychris opened this issue Sep 8, 2017 · 0 comments
Open

Update lint configurations #142

themightychris opened this issue Sep 8, 2017 · 0 comments
Labels
A-sencha-app Area: General app infrastructure, viewport, and navigation C-chore Category: Necessary work for core-maintainers that is not a bug or feature E-easy Effort: Straightforward; recommended for a new contributor L-sencha Language: Sencha/Ext JS (JavaScript)

Comments

@themightychris
Copy link
Contributor

Erase all /*jslint ...*/ configs at the top of source files, as the project-wide eslint config is used now instead.

Also sort class requires by namespace, Ext first, then packages, then app. Prefix external namespace sections with /* global XXXX */ to mark it safe to the linter within that file, e.g.:

    requires: [
        'Ext.window.MessageBox',

        /* globals SlateAdmin */
        'SlateAdmin.API'
    ],
@themightychris themightychris added A-sencha-app Area: General app infrastructure, viewport, and navigation C-chore Category: Necessary work for core-maintainers that is not a bug or feature E-easy Effort: Straightforward; recommended for a new contributor L-sencha Language: Sencha/Ext JS (JavaScript) labels Sep 8, 2017
@themightychris themightychris added this to the App best practices milestone Sep 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-sencha-app Area: General app infrastructure, viewport, and navigation C-chore Category: Necessary work for core-maintainers that is not a bug or feature E-easy Effort: Straightforward; recommended for a new contributor L-sencha Language: Sencha/Ext JS (JavaScript)
Projects
None yet
Development

No branches or pull requests

1 participant