Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues on macOS on latest #137

Open
dimitre opened this issue Jan 27, 2025 · 0 comments
Open

Multiple issues on macOS on latest #137

dimitre opened this issue Jan 27, 2025 · 0 comments

Comments

@dimitre
Copy link

dimitre commented Jan 27, 2025

I've noticed the check for define _MACOS was not enough to auto detect macos, so I've changed to #elif defined(__APPLE__)
But then I found some errors due to non existent function
grabScanData
Looking for the objects I changed to grabScanDataHq, and rplidar_response_measurement_node_t -> rplidar_response_measurement_node_hq_t

and found the members are invalid

nodes[i].sync_quality
nodes[i].angle_q6_checkbit
nodes[i].distance_q2

but I don't know if they are equivalent now

sl_u16   angle_z_q14;
sl_u32   dist_mm_q2;
sl_u8    quality;
sl_u8    flag;

after this changes I had to change

std::string getSerialPath() const { serial_path_; }

to

std::string getSerialPath() const { return serial_path_; }

Is this right? or you will put back grabScanData ? thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant