Expose Convolution Api #2797
Merged
Expose Convolution Api #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
requested review from
tocsoft,
antonfirsov,
dlemstra and
brianpopow
antonfirsov
reviewed
Nov 14, 2024
Comment on lines
+81
to
+89
| public static IImageProcessingContext Convolve( | ||
| this IImageProcessingContext source, | ||
| Rectangle rectangle, | ||
| DenseMatrix<float> kernelXY, | ||
| bool preserveAlpha, | ||
| BorderWrappingMode borderWrapModeX, | ||
| BorderWrappingMode borderWrapModeY) | ||
| => source.ApplyProcessor(new ConvolutionProcessor(kernelXY, preserveAlpha, borderWrapModeX, borderWrapModeY), rectangle); | ||
| } |
There was a problem hiding this comment.
I would add integration tests that excercise at least 2 different values for all parameters to validate that everything is plumbed through end-to-end, otherwise LGTM.
There was a problem hiding this comment.
I'll have alook. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
See the roadmap discussion at #2533
Adds a general convolution API that accepts a
DenseMatrix<float>to describe the convolution kernel.All this stuff has been the plumbing for various processors over the years and should be exposed publicly now it's solid.