Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Region and implement "ProcessInsideShape" within ImageSharp.Drawing #105

Closed
antonfirsov opened this issue Nov 20, 2020 · 2 comments · Fixed by #150
Closed

Remove Region and implement "ProcessInsideShape" within ImageSharp.Drawing #105

antonfirsov opened this issue Nov 20, 2020 · 2 comments · Fixed by #150

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Nov 20, 2020

We want to enable clipping interest region of arbitrary processors by an arbitrary polygon. If we agree that solving this problem with Region is not feasible, we need to remove that type for 1.0, and add the ProcessInsideShape utility to the core library.

For more details, see the discussion starting with #96 (comment).

@antonfirsov antonfirsov added this to the 1.0.0-rc.1 milestone Nov 20, 2020
@antonfirsov antonfirsov changed the title Remove Region and implement "ProcessInsideShape" within the library Remove Region and implement "ProcessInsideShape" within ImageSharp.Drawing Nov 20, 2020
@JimBobSquarePants
Copy link
Member

This means removing (not refactoring) any current extensions utilizing Region yes?

  • ClearRegionExtensions
  • FillRegionExtensions

We'd then keep ShapeRegion as an internal type to use in FillRegionProcessor

@antonfirsov
Copy link
Member Author

Yes, we should remove them, just let's make sure we have equivalent functionality in other extension classes using IPath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants