Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into using @changeset/action on merge to main instead of running yarn release manually. #161

Closed
charlespwd opened this issue Oct 10, 2023 · 1 comment · Fixed by #693
Assignees
Labels
enhancement New feature or request tech debt

Comments

@charlespwd
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Turns out @changeset/action can be pretty smart about updating existing PRs and stuff. Might be worth a look.

@charlespwd
Copy link
Contributor Author

We're getting more and more contributions and are now more at risk from a new problem:

  • making a release that has unreleased / unbumped version changes in it.

So it’s kind of hard to explain but the risk here is that:

  • I just merged something on main that updates package X & has a changeset for it
  • Someone ran yarn release prior to me merging those changes on main
    • package X did not have any changeset for it.
    • Its version did not change.
  • Someone opened the version bump PR. It was accepted.
  • Someone merges the version bump PR on main
    • main now has my new changes (no version bump)
    • main has new version in all the package.json of all the repos except for X
  • Someone runs the GitHub workflow to push stuff to npm
  • We run yarn build && yarn publish from main in CI
  • Package Y breaks in prod because it points to package X at its old version

TL;DR Right now folks need to rebase & rerun yarn release every time someone merges to main.

The GitHub workflow would eliminate this possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants