Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove private_shop configuration from Context generating a new app #1926

Open
kennyadsl opened this issue Nov 28, 2024 · 1 comment
Open

Remove private_shop configuration from Context generating a new app #1926

kennyadsl opened this issue Nov 28, 2024 · 1 comment

Comments

@kennyadsl
Copy link
Contributor

Overview/summary

Geneating a new app with shopify_app, we are copying the private_shop configuration in the setup.

Is this still needed? I couldn't find any documentation on in which cases this option makes sense to be used. If we can remove it, I can make a PR for that.
@matteodepalo
Copy link
Contributor

Hi @kennyadsl, I'll check this with the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matteodepalo @kennyadsl