Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polaris Empty state illustration rendering very small #810

Closed
markiiikram opened this issue Jan 2, 2019 · 5 comments · May be fixed by #12882
Closed

Polaris Empty state illustration rendering very small #810

markiiikram opened this issue Jan 2, 2019 · 5 comments · May be fixed by #12882

Comments

@markiiikram
Copy link
Contributor

Issue summary

Hi Team, Happy New Year! When building Build a Shopify app with Node and React the Polaris Empty state component illustration sometimes renders very small.

Expected behavior

It should render as shown in Polaris https://polaris.shopify.com/components/structure/empty-state

Actual behavior

screen shot 2019-01-02 at 11 22 35 am

screen shot 2019-01-02 at 11 05 01 am

Steps to reproduce the problem

  1. Complete the Build your user interface with Polaris of the Tutorial

Reduced test case

Specifications

  • Are you using the React components? (Y/N): Y
  • Polaris version number: 3.2.1
  • Browser: Chrome
  • Device: MacBook Pro
  • Operating System: Mojave 10.14.1

cc: @katiedavis
@AndrewMusgrave
Copy link
Member

Odd, shouldn't the illustration be rendering under the title and actions?

@solonaarmstrong-zz
Copy link

solonaarmstrong-zz commented Jan 4, 2019 •
edited
Loading

Weird, I thought this was fixed.

@AndrewMusgrave AndrewMusgrave added Bug Something is broken and not working as intended in the system. Good for learning labels Jan 4, 2019
@markiiikram
Copy link
Contributor Author

@nwtn is getting a slightly different version of this problem today.

Screen Shot 2019-03-11 at 11 28 03 AM

Related to this issue is a "double rendering" that seems to happen because of SSR and AppProvider. AppProvider checks for client, it's not ready, then it checks it again and renders "properly".

broken-empty-state

@yourpalsonja yourpalsonja added Good first issue and removed Bug Something is broken and not working as intended in the system. Good for learning labels Apr 17, 2019
@yourpalsonja
Copy link
Contributor

This repo getting a makeover! We want to make it easier to find existing issues, remove duplicates, and increase community engagement. If you issue is closed, re-labelled, or moved, don’t panic–it may be a duplicate (check the comments), or there is a new label or repository that work better.

If you disagree with the changes or have any other thoughts on how we can make Polaris better, please let us know!

@ghost
Copy link

ghost commented Oct 14, 2019

This issue has been inactive for 180 days and labeled with Icebox. It will be closed in 7 days if there is no further activity.

@ghost ghost added the Icebox label Oct 14, 2019
@ghost ghost closed this as completed Oct 21, 2019
@TheGreatSimo TheGreatSimo mentioned this issue Nov 8, 2024
Open
6 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EmptyState] Add documentation for onAction prop usage TheGreatSimo/polaris
4 participants
@yourpalsonja @markiiikram @solonaarmstrong-zz @AndrewMusgrave