Replies: 3 comments
-
Sounds like a good solution. I'm down for it 🙌🏽 |
Beta Was this translation helpful? Give feedback.
0 replies
-
@krystalcampioni's comment++ |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I noticed that there's a few instances in the repo where the
theme
prop isn't being correctly passed down to child components. This means that theDefault
theme is always being used.Half the problem here is that
theme
is optional becauseuseTheme
uses theDefault
theme if thetheme
prop is omitted. We don't get warned if the prop isn't passed down.My idea is that we:
theme = 'Default'
in those root components to set the default theme.theme
required for any child component that uses it.Beta Was this translation helpful? Give feedback.
All reactions