-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vernier profiles can't be viewed locally #142
Comments
@gmcgibbon there is actually a PR waiting for you to review #111 we had reviewed it together but i think it fell off the radar. I just rebased it and re-fixed rubocop. |
#111 is merged, which helps, but I'm still going to work on a local version of the middleware and that requires change the profile-viewer. Working on that next. |
Thanks @gmcgibbon ! |
This is fixed. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The default viewing profile action doesn't work with Vernier profiles:
app_profiler/lib/app_profiler/profile/vernier.rb
Lines 18 to 22 in 7a0f861
We should implement this so Vernier can be use out-of-the-box like Stackprof can. We can probably use profile-viewer like we do speedscope.
The text was updated successfully, but these errors were encountered: