Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre 1.13 to 1.13+ world does not work #1

Open
ShibeTemple opened this issue Mar 24, 2021 · 0 comments
Open

Pre 1.13 to 1.13+ world does not work #1

ShibeTemple opened this issue Mar 24, 2021 · 0 comments
Assignees
Labels
bug Something isn't working parser issue related to the parser of anvil files

Comments

@ShibeTemple
Copy link
Owner

Issue is present with handling of NBT data within OldBlock class. Possibly need to create a new-block-object with the same properties (referenced from OldBlock object) instead of just referencing the same object. <-- within core loop of negative.py.

This issue could be solved with some brain time but it comes with larger issues behind the current anvil parser. Will keep issue open for documentation purposes, however re-write of anvil parser will take priority in work-time.

====================================================================================================
ALL ARGUMENTS:  ['negative.py', 'Pre', 'Post', 'new', 'output', '-t', '12']
ARGUMENTS:  ['-t', '12']
pre: Pre post: Post new: new output: output
wd: A:\!\M\Minecraft Negative\aaron test 1
====================================================================================================
Thread count set to (12)
REGION[ -01 000 ] new thread
REGION[ 000 000 ] new thread
REGION[ -01 000 ] region file exists in all
REGION[ 000 000 ] region file exists in all
Traceback (most recent call last):
  File "A:\!\M\Minecraft Negative\aaron test 1\negative.py", line 260, in <module>
    threading_results = pool.starmap(process_region, zip(filelist, itertools.repeat(wd_pre_region), itertools.repeat(wd_post_region), itertools.repeat(wd_new_region), itertools.repeat(wd_output_region), itertools.repeat(include_bedrock)))
  File "C:\Users\bjg15\AppData\Local\Programs\Python\Python39\lib\multiprocessing\pool.py", line 372, in starmap
    return self._map_async(func, iterable, starmapstar, chunksize).get()
  File "C:\Users\bjg15\AppData\Local\Programs\Python\Python39\lib\multiprocessing\pool.py", line 771, in get
    raise self._value
  File "C:\Users\bjg15\AppData\Local\Programs\Python\Python39\lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "C:\Users\bjg15\AppData\Local\Programs\Python\Python39\lib\multiprocessing\pool.py", line 51, in starmapstar
    return list(itertools.starmap(args[0], args[1]))
  File "A:\!\M\Minecraft Negative\aaron test 1\negative.py", line 234, in process_region
    output_region.save(file_to_save)
  File "A:\!\M\Minecraft Negative\aaron test 1\anvil\empty_region.py", line 218, in save
    nbt_data = chunk.save()
  File "A:\!\M\Minecraft Negative\aaron test 1\anvil\empty_chunk.py", line 161, in save
    sections.tags.append(s.save())
  File "A:\!\M\Minecraft Negative\aaron test 1\anvil\empty_section.py", line 152, in save
    tag.tags.append(nbt.TAG_String(name='Name', value=block.name()))
AttributeError: 'OldBlock' object has no attribute 'name'
@ShibeTemple ShibeTemple self-assigned this Mar 24, 2021
@ShibeTemple ShibeTemple added bug Something isn't working help wanted Extra attention is needed parser issue related to the parser of anvil files and removed help wanted Extra attention is needed labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser issue related to the parser of anvil files
Projects
None yet
Development

No branches or pull requests

1 participant