Don't create a result on validation failure with MVC-Controllers and just continue the request pipeline

[snpz]

Hi.

I'm currently trying to implement AutoValidation for my controller methods. Validation happens as expected, but in case of a validation error the Controller-Action is never called as the pipeline gets aborted before.

I'd like to keep our current logic which looks something like this:

public ActionResult Update(PaymentInformationViewModel model)
{
    if (!ModelState.IsValid)
        return View("PaymentInformation/Update", model);

I think this could be handled by another configuration setting that defines to still continue running the pipeline even if a validation error occurs. Maybe I'm also overlooking some other possibility to reach my goal.

Any thoughts on this?

[snpz]

I just realized there is even an
open PR from @icnocop for something similar. Will this make it into the project?

[mvdgun]

Hi @snpz, I think it would be a nice feature to have and will make it into the project. I'm a little short on time at the moment so haven't gotten around to reviewing.

[unusualnan]

I’m also looking forward to this feature being merged.

[JimBobSquarePants]

I'm glad I found this discussion.

Given the link from the FluentValidations docs I was under the impression that this was a like-for-like replacement for the existing depreciated functionality. As it stands this is not the case and represents a significant breaking change.

[mvdgun]

@JimBobSquarePants I initially created this library to cater to my own needs being primarily automatic model validation for Web API projects. Over the time the project has grown and is adopting more features such as this one (when I get around to reviewing/merging :)).

[mvdgun]

I am working on a v2 release of the library. A part of the v2 release is going to be a result factory rework. It is going to be possible to return a null value to the action filter to prevent the action filter from short circuiting. Besides returning null I will also expose a new parameter that will allow you to prevent the validation filter from short circuiting the request.

public Task<IActionResult?> Create(MvcAutoValidationContext mvcAutoValidationContext)
{
    return Task.FromResult<IActionResult?>(null);
}

[mvdgun]

@snpz I just released v2

[snpz]

Thanks for the release and mention, I will test this soon (in about 1-2 weeks probably) and give feedback if any.