Technical debt

[CaraHill]

This thread is meant to capture any work that needs to be done towards reducing technical debt for the pancake-backend app. Please feel free to add anything has been missed.

Conversely, please track when something has been done so that this list stays up to date.

• Most of the tests in the test suite only test happy paths, but it would be great if sad path/edge case specs could be written, especially for the RebateForm journey (not signed to batched).

• When in Alpha, RebateForms calculated their own rebate amount, using an instance method and storing the result in an attribute. Beta no longer does this, but the method and attribute remain on the RebateForm model. If there is no intention to return to this behaviour, this code should be removed.

• There are a number of files (views, in particular, ie councils and properties) that were used in Alpha and are not used in Beta but remain in the app. They could be deleted.

• The concept of a RatesPayer is not used in Beta. This object, and all code relating to it, can be removed.

[issue-label-bot]

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.79. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[mischa-s]

Rebate amount, extra views and rates payer have all been addressed - last remaining piece on this issue is sad path /edge case testing