From a905eef46ed8fd386313d1c0280d7df4e3fb5740 Mon Sep 17 00:00:00 2001
From: Michael Chirico <chiricom@google.com>
Date: Thu, 20 Jun 2024 09:30:46 -0700
Subject: [PATCH 1/3] Explicitly set locale for qtab test file
---
tests/testthat/test-qtab.R | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/testthat/test-qtab.R b/tests/testthat/test-qtab.R
index 6994daf3..1ff67781 100644
--- a/tests/testthat/test-qtab.R
+++ b/tests/testthat/test-qtab.R
@@ -1,6 +1,6 @@
context("qtab")
-
+withr::local_locale(c(LC_COLLATE = "C"))
set.seed(101)
wldNA <- na_insert(wlddev)
From da84170e27184f417654497f2c305fbef03d2ee1 Mon Sep 17 00:00:00 2001
From: Michael Chirico <chiricom@google.com>
Date: Thu, 20 Jun 2024 09:34:37 -0700
Subject: [PATCH 2/3] Also in test-GRP
---
tests/testthat/test-GRP.R | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/testthat/test-GRP.R b/tests/testthat/test-GRP.R
index 338428e9..8d6a8b5e 100644
--- a/tests/testthat/test-GRP.R
+++ b/tests/testthat/test-GRP.R
@@ -91,6 +91,7 @@ expect_identical(lapply(rc, function(x) unattrib(radixorderv(gv(wldNA, x), decre
test_that("GRP works as intended", {
+ withr::local_locale(c(LC_COLLATE = "C"))
expect_visible(GRP(unname(as.list(mtcars))))
expect_visible(GRP(unname(as.list(mtcars)), 8:9))
From 68887116435736837616db725c01faa98addc4cb Mon Sep 17 00:00:00 2001
From: Michael Chirico <chiricom@google.com>
Date: Thu, 20 Jun 2024 10:06:20 -0700
Subject: [PATCH 3/3] Need withr in Suggests explicitly
---
DESCRIPTION | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DESCRIPTION b/DESCRIPTION
index fdad766e..dafeebe8 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -42,6 +42,6 @@ Imports: Rcpp (>= 1.0.1)
LinkingTo: Rcpp
Suggests: fastverse, data.table, magrittr, kit, xts, zoo, plm, fixest, vars,
RcppArmadillo, RcppEigen, tibble, dplyr, ggplot2, scales, microbenchmark,
- testthat, covr, knitr, rmarkdown
+ testthat, covr, knitr, rmarkdown, withr
VignetteBuilder: knitr