forked from alex85k/wingetopt
-
Notifications
You must be signed in to change notification settings - Fork 7
/
meson.build
271 lines (248 loc) · 12.7 KB
/
meson.build
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
# Modifications Copyright 2022 Seagate Technology and/or its Affiliates
# Setting meson version >=0.53 since that was tested and worked as expected on one system inside Seagate
project(
'wingetopt',
'c',
version: '0.98',
license : ['ISC', 'BSD-3-Clause'],
meson_version: '>= 0.53',
default_options: [
'warning_level=3',
'default_library=static'
],
)
compiler = meson.get_compiler('c')
c_args = []
warning_flags = [ ]
linker_flags = [ ] #additional linker flags to add per-compiler for hardening.
if compiler.get_id().contains('gcc') or compiler.get_id().contains('clang')
#TODO: Add -Wcast-align=strict and fix these issues to help ensure better portability
#NOTE: -Wsign-conversion can be useful while debugging, but there are numerous places this shows up
# and it is not useful, so only add it while debugging.
#NOTE: 4/4/2024 - adding flags from https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++
warning_flags = [
# '-Wcast-align=strict',
'-Wshadow=compatible-local',
'-Wvla',
'-Wfloat-equal',
'-Wnull-dereference',
'-Wunused-const-variable',
'-Wunused-parameter',
'-Wunused-value',
'-Wduplicated-cond',
'-Wjump-misses-init',
'-Wstringop-overflow',
'-Wlogical-op',
'-Wshift-overflow',
'-Wshift-overflow=1',
'-Wshift-overflow=2',
'-Wdouble-promotion',
'-Wformat-security',
'-Wold-style-definition',
'-Wstrict-prototypes',
'-Wmissing-declarations',
'-Wmissing-prototypes',
'-Wchar-subscripts',
'-Wundef',
'-Wformat',
'-Wformat=2',
'-Wint-conversion',#-Warith-conversion
'-Wenum-conversion',
'-Wfloat-conversion',
'-Wint-to-pointer-cast',
'-Wimplicit-fallthrough',
'-D_GLIBCXX_ASSERTIONS',
'-fstrict-flex-arrays=1', #NOTE: Using level 1 since Windows often uses [1] at the end of it's structures. opensea-*libs has used this in a few places too.
'-fstack-protector-strong',
'-fno-delete-null-pointer-checks',
'-fno-strict-overflow',
'-fno-strict-aliasing',
'-ftrivial-auto-var-init=zero',
'-Wtrampolines', #GCC only at this time
'-Werror=implicit',
'-Werror=incompatible-pointer-types',
'-Wincompatible-pointer-types-discards-qualifiers',
'-Werror=int-conversion',
'-Werror=implicit-int',
'-Woverlength-strings',
'-Wnewline-eof',
'-Wno-c23-extensions', #We do not want this warning since we are already checking for when C23 extensions are available before we use them. If not, we use a compiler specific definition, or make it an empty definition.
'-Wparentheses',
'-Wextra-semi',
'-Wcast-qual',
'-Werror=sometimes-uninitialized',
'-Wuninitialized',
'-Wunevaluated-expression',
'-Wunsequenced',
'-Wvarargs',
'-Wwrite-strings',
'-Wrestrict',
'-Wstringop-truncation',
'-Werror=trigraphs',
'-Wunreachable-code',
'-Wcomment',
'-Wsequence-point',
'-Wreturn-type',
'-fvisibility=hidden', #to work similarly to Window's DLL import/export
]
if compiler.get_id().contains('gcc') and compiler.version().version_compare('>=10.0')
#only enable the sign conversion warning on versions 10 and up because it is way too noisy on earlier GCC versions than it is useful-TJE
warning_flags += '-Wsign-conversion'
endif
if compiler.get_id().contains('gcc') and target_machine.system() == 'windows'
#According to the link below, this is not needed in Windows...it also causes a bug in some versions of GCC for Windows.
#https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90458
#NOTE: While this appears to be fixed for versions 11 and 12, the current CI is failing on this with
# version 12.2. If we want to or need to enable this, it should be done based on which versions we
# know have been patched for this. -TJE
else
warning_flags += '-fstack-clash-protection'
endif
if target_machine.cpu_family() == 'ppc64'
#power pc builds generate a lot of warnings/notes about ABI changes since GCC-5
#this flag is disabling them because this is way too noisy.
warning_flags += ['-Wno-psabi']
elif target_machine.cpu_family() == 'x86_64'
warning_flags += ['-fcf-protection=full'] #this may be linux only at this time.
elif target_machine.cpu_family() == 'aarch64'
warning_flags += ['-mbranch-protection=standard']
endif
linker_flags += [
'-Wl,-z,nodlopen',
'-Wl,-z,noexecstack',
'-Wl,-z,relro',
'-Wl,-z,now'
]
fortifytest = ''' #include <stdio.h>
int main() {
return 0;
}
'''
fortifyresult = compiler.compiles(fortifytest, name : '_FORTIFY_SOURCE override', args : ['-U_FORTIFY_SOURCE', '-D_FORTIFY_SOURCE=5', '-Werror'])
if fortifyresult == true
warning_flags += ['-U_FORTIFY_SOURCE', '-D_FORTIFY_SOURCE=3']
endif
elif compiler.get_id().contains('msvc')
#See here for enabling/disabling msvc warnings:
#https://learn.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=msvc-170
#warnings off by default: https://learn.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=msvc-170
warning_flags = [
#Turn off the following warnings. If using /wall in Windows, many of these show all over the Windows API
#This is likely not an issue with meson, but matching VS project files for now
'/wd4214', # nonstandard extension used : bit field types other than int
'/wd4201', # nonstandard extension used : nameless struct/union
'/wd4668', # 'symbol' is not defined as a preprocessor macro, replacing with '0' for 'directives'. While like -Wundef, this creates too many warnings in system headers to use
'/wd4820', # 'bytes' bytes padding added after construct 'member_name'
'/wd4710', # 'function' : function not inlined
'/wd5045', # Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
'/wd4711', # function 'function' selected for inline expansion
'/wd4324', # 'struct_name' : structure was padded due to __declspec(align())
'/wd4221', # nonstandard extension used : 'identifier' : cannot be initialized using address of automatic variable
'/wd4204', # nonstandard extension used : non-constant aggregate initializer
'/wd5105', # macro expansion producing 'defined' has undefined behavior
'/wd4746', # volatile access of '<expression>' is subject to /volatile:[iso|ms] setting; consider using __iso_volatile_load/store intrinsic functions.
#Turn on the following warnings to make the output more useful or like GCC/clang
'/w14255', # 'function' : no function prototype given: converting '()' to '(void)'
'/w14062', # enumerator 'identifier' in switch of enum 'enumeration' is not handled
'/w14101', # 'identifier' : unreferenced local variable
'/w14189', # 'identifier' : local variable is initialized but not referenced
'/w15031', # #pragma warning(pop): likely mismatch, popping warning state pushed in different file
'/w15032', # detected #pragma warning(push) with no corresponding #pragma warning(pop)
'/w15262', # implicit fall-through occurs here; are you missing a break statement? Use [[fallthrough]] when a break statement is intentionally omitted between cases
'/w14255', # 'function' : no function prototype given: converting '()' to '(void)' #NOTE: Only needed for /Wall, otherwise enabling can be good-TJE
'/w14242', # identifier conversion from type 1 to type 2, possible loss of data (matches -wconversion above)
'/w14254', # operator conversion from type 1 to type 2, possible loss of data (matches -wconversion above)
'/w14287', # operator: unsigned/negative constant mismatch (matches -wconversion above)
'/w14296', # operator: expression is always false
'/w14365', # action: conversion from type 1 to type 2, signed/unsigned mismatch (matches -wconversion above)
'/w14388', # implicit conversion warning during a comparison (matches -wconversion above)
'/w14545', # expression before comma evaluates to a function which is missing an argument list
'/w14546', # function call before comma missing argument list
'/w14547', # 'operator' : operator before comma has no effect; expected operator with side-effect
'/w14548', # expression before comma has no effect; expected expression with side-effect
'/w14549', # 'operator1': operator before comma has no effect; did you intend 'operator2'?
'/w14574', # 'identifier' is defined to be '0': did you mean to use '#if identifier'?
'/w14605', # '/Dmacro' specified on current command line, but was not specified when precompiled header was built
'/w14555', # expression has no effect; expected expression with side-effect
'/w14774', # 'string' : format string expected in argument number is not a string literal
'/w14777', # 'function' : format string 'string' requires an argument of type 'type1', but variadic argument number has type 'type2'
'/w14826', # Conversion from 'type1' to 'type2' is sign-extended. This may cause unexpected runtime behavior (more -wconversion)
'/w15219', # implicit conversion from 'type-1' to 'type-2', possible loss of data (-wconversion)
'/w15240', # 'attribute-name': attribute is ignored in this syntactic position
'/w15245', # 'function': unreferenced function with internal linkage has been removed
'/w14555', # expression has no effect; expected expression with side-effect
'/w15264', # 'variable-name': 'const' variable is not used
'/w24302', # 'conversion': truncation from 'type1' to 'type2'
'/w14311', # 'variable': pointer truncation from 'type' to 'type'
'/w14312', # 'operation': conversion from 'type1' to 'type2' of greater size
'/w14319', # 'operator': zero extending 'type1' to 'type2' of greater size
#Treat the following as errors
'/we4431', # missing type specifier - int assumed. Note: C no longer supports default-int
'/we4905', # wide string literal cast to 'LPSTR'
'/we4906', # string literal cast to 'LPWSTR'
'/we4837', # trigraph detected: '??character' replaced by 'character'
'/we4628', # digraphs not supported with -Ze. Character sequence 'digraph' not interpreted as alternate token for 'char'
'/we4289', # nonstandard extension used : 'var' : loop control variable declared in the for-loop is used outside the for-loop scope
'/we4464', # relative include path contains '..'
'/GS', #security cookie for stack protection
'/sdl', #adds recommended security development lifecycle checks
'/Qspectre',
'/guard:cf', #control flow guard
'/d2guard4', #control flow guard
]
if compiler.has_argument('/std:c17')
c_std = 'c17'
endif
linker_flags += [
'/guard:cf', #control flow guard
'/SafeSEH', #on by default in x64 so it is unrecognized otherwise.
'/NXCOMPAT', #data execution prevention
'/dynamicbase', #address space randomization
]
endif
add_project_arguments(compiler.get_supported_arguments(warning_flags), language : 'c')
add_project_link_arguments(compiler.get_supported_link_arguments(linker_flags), language : 'c')
if compiler.get_id() == 'msvc'
# -D_CRT_SECURE_NO_WARNINGS is not needed as the code checks flags to switch to MSFT preferred functions as needed-TJE
if get_option('default_library') == 'shared'
c_args += [
'-DBUILDING_WINGETOPT_DLL',
'-DWINGETOPT_SHARED_LIB',
]
endif
endif
add_project_arguments(compiler.get_supported_arguments(c_args), language : 'c')
if compiler.has_header('stdint.h')
add_project_arguments('-DHAVE_STD_INT', language : 'c')
endif
if compiler.has_header_symbol('stdlib.h', '__STDC_LIB_EXT1__')
add_project_arguments(['-D__STDC_WANT_LIB_EXT1__=1'], language : 'c')
endif
if compiler.has_function('fprintf_s', prefix : '#define __STDC_WANT_LIB_EXT1__ 1\n#include <stdio.h>\n')
add_project_arguments(['-DHAVE_FPRINTF_S'], language : 'c')
endif
if compiler.has_function('vfprintf_s', prefix : '#define __STDC_WANT_LIB_EXT1__ 1\n#include <stdio.h>\n')
add_project_arguments(['-DHAVE_VFPRINTF_S'], language : 'c')
endif
if compiler.has_function('getenv_s', prefix : '#define __STDC_WANT_LIB_EXT1__ 1\n#include <stdlib.h>\n')
add_project_arguments(['-DHAVE_GETENV_S'], language : 'c')
elif compiler.has_function('secure_getenv', prefix : '#define _GNU_SOURCE\n#include <stdlib.h>\n')
#TODO: check if user has disabled using this function through compile option
add_project_arguments(['-D_GNU_SOURCE', '-DHAVE_SECURE_GETENV'], language : 'c')
elif compiler.has_function('__secure_getenv', prefix : '#define _GNU_SOURCE\n#include <stdlib.h>\n')
#TODO: check if user has disabled using this function through compile option
add_project_arguments(['-D_GNU_SOURCE', '-DHAVE___SECURE_GETENV'], language : 'c')
endif
wingetopt_lib = library(
'wingetopt',
'src/getopt.c',
include_directories: include_directories(
'src',
),
)
wingetopt_dep = declare_dependency(
link_with: wingetopt_lib,
include_directories: include_directories(
'src',
),
)