openSeaChest_NVMe --getFeatures 1 not getting the right Arbitration Burst value

[jaythegreatman]

Problem

Arbitration Burst returned by --getFeatures 1 does not match the raw value returned by --getFeatures list

Expected behavior

--getFeatures 1 gets the lower 3 bits of the raw value as Arbitration Burst

How to reproduce

openSeaChest_NVMe --getFeatures list returns

 Feature ID     Raw Value (DWORD 0)
===============================
    01h         0x00000004
...

While openSeaChest_NVMe --getFeatures 1 returns

        Arbitration & Command Processing Feature
=============================================
Hi  Priority Weight (HPW) :             0x00
Med Priority Weight (MPW) :             0x00
Low Priority Weight (LPW) :             0x00
Arbitration Burst    (AB) :             0x00

Deployment information

Any

Additional information

opensea-operations/src/nvme_operations.c

Line 128 in 63e829f

printf("Arbitration Burst (AB) :\t\t0x%02X\n", featureCmd.featSetGetValue & 0x00000003);

Here it's getting the lower 2 bits.
Please refer to NVM Express Base Specification, Revision 2.0d, Page 312, Figure 318, Bits 02:00

[vonericsen]

@jaythegreatman,

Thank you for reporting this bug. I will correct this today.

[vonericsen]

I am marking this closed since this fix was part of the openSeaChest v24.08.1 release.

Please feel free to reopen this if there are other issues with this output