Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce md5 SQL function #785

Closed
IgnisDa opened this issue Jun 14, 2024 · 3 comments · Fixed by #786
Closed

Introduce md5 SQL function #785

IgnisDa opened this issue Jun 14, 2024 · 3 comments · Fixed by #786

Comments

@IgnisDa
Copy link
Contributor

IgnisDa commented Jun 14, 2024

Motivation

I would like to call the MD5 SQL function. Both Postgres and MySQL have support for it and have the same function signature. SQLite does not have support.

Proposed Solutions

Right now I am using Func::custom.

Additional Information

I am willing to make a PR.
@IgnisDa IgnisDa mentioned this issue Jun 14, 2024
Merged
@IgnisDa
Copy link
Contributor Author

IgnisDa commented Jun 14, 2024

@billy1624 @tyt2y3 I made a PR for the same. Can you take a look?

@RichardWGNR
Copy link

The idea is good, but it is not good to create a function for every sneeze. Instead, you can create your own implementation of Func:: or use macros.

Otherwise, the code base will be clogged with functions supported in one DBMS but not supported in another.

@IgnisDa
Copy link
Contributor Author

IgnisDa commented Jul 13, 2024

@RichardWGNR I'm already using Function::cust but how can this be done with macros? Using Function::cust makes the code very verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Md5 function IgnisDa/sea-query
2 participants
@IgnisDa @RichardWGNR