Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] innounp (and hence scoop) doesn't support inno setup 6.3 #6157

Open
milnak opened this issue Sep 28, 2024 · 4 comments
Open

[Bug] innounp (and hence scoop) doesn't support inno setup 6.3 #6157

milnak opened this issue Sep 28, 2024 · 4 comments
Labels

Comments

@milnak
Copy link

milnak commented Sep 28, 2024

Bug Report

Current Behavior

install milnak/knobkraftorm
will fail because the exe uses innosetup 6.3

> innounp -t D:\temp\knobkraft_orm_setup_2.4.0.exe
Signature detected: Inno Setup Setup Data (6.3.0)
This is not directly supported, but i'll try to unpack it as version 5602
; Version detected: 6300
Critical error: The setup files are corrupted. Please obtain a new copy of the program.

Expected Behavior

Should extract

Possible Solution

Use innounpacker which supports later innosetup versions. I have a manifest for this here

@milnak milnak added the bug label Sep 28, 2024
@milnak
Copy link
Author

milnak commented Sep 28, 2024

looks like this should have been fixed with #6028 but that doesn't seem to be the case?

> scoop uninstall -p main/innounp
Uninstalling 'innounp' (0.50).
Removing shim 'innounp.shim'.
Unlinking ~\scoop\apps\innounp\current
Removing persisted data.
'innounp' was uninstalled.

> scoop install milnak/knobkraftorm
WARN  Purging previous failed installation of knobkraftorm.
ERROR 'knobkraftorm' isn't installed correctly.
Removing older version (2.4.0).
'knobkraftorm' was uninstalled.
Installing 'innounp' (0.50) [64bit] from 'Main' bucket
Loading innounp050.rar from cache
Checking hash of innounp050.rar ... ok.
Extracting innounp050.rar ... done.
Linking ~\scoop\apps\innounp\current => ~\scoop\apps\innounp\0.50
Creating shim for 'innounp'.
'innounp' (0.50) was installed successfully!

@milnak
Copy link
Author

milnak commented Sep 28, 2024

The mitigation given in other bugs is "scoop install versions/innounp-unicode" which seems to fix the problem, but is unideal. Why not just set innounp-unicode to the default?

@milnak
Copy link
Author

milnak commented Sep 28, 2024

For now, manifest authors can force this as needed, e.g.
"depends": "versions/innounp-unicode",

@HUMORCE
Copy link
Member

HUMORCE commented Sep 29, 2024

While this may be a temporary, as a possible dependency of Scoop Core, innounp-unicode should be placed on main bucket. IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants