-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array constructors using StaticInt
as dimensions
#70
Comments
I think this eventually should happen but I'm nervous to make a decision. It seems like one of those things that will upset people no matter what package we choose. |
I have some changes planned for StrideArraysCore when I get the time (mostly, don't store explicit strides whenever they can be calculated from |
I got Polyester.jl's tests passing locally, but the testsuite creates a lot of arrays using |
I see, so this is actually causing downstream test failures. In an ideal world we could just put a linear buffer inside |
Another example of resulting test failures, but here from within a package rather than within the test suite: https://github.com/PumasAI/SimpleChains.jl/runs/7045158658?check_suite_focus=true |
Previously related functions were just converting to |
But it may be nice to pick a blessed package like
StrideArraysCore
for some of these (e.g.zeros
,ones
) to construct arrays with statically sized dimensions.The text was updated successfully, but these errors were encountered: