-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Nothing
with Missing
#29
Comments
Would it make more sense to expand |
Do you mean that |
I understand that, and I use so +1 |
We've used the convention of returning
nothing
when something isn't known at compile time (e.g.,known(1) == nothing
). I think it might actually make more sense to usemissing
. A minor motivation for this could be that the "known" information is "missing" at compile time, so it has a more clear meaning. But I think the biggest benefit is that you can still operate on return fromknown
. For example,ArrayInterface.known_length(x) = prod(known_size(x))
would work.This would be a breaking change and could require some extra work down stream, so I want to get opinions on this before getting a bunch of PRs ready.
The text was updated successfully, but these errors were encountered: