Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : NOMAD #27

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Feat : NOMAD #27

merged 7 commits into from
Aug 22, 2024

Conversation

ayushinav
Copy link
Contributor

@ayushinav ayushinav commented Aug 21, 2024

Adds NOMAD

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.16%. Comparing base (d22b523) to head (20609b9).
Report is 1 commits behind head on main.

Files Patch % Lines
src/utils.jl 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   94.78%   97.16%   +2.38%     
==========================================
  Files           7        8       +1     
  Lines         115      141      +26     
==========================================
+ Hits          109      137      +28     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@avik-pal avik-pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run the formatter and add tests covering the missing coverage lines

@ayushinav ayushinav requested a review from avik-pal August 22, 2024 00:35
Copy link
Member

@avik-pal avik-pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vcat is usually faster than cat(...; dims=1)

src/nomad.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
@avik-pal avik-pal self-requested a review August 22, 2024 01:40
@avik-pal avik-pal merged commit 5fd7028 into SciML:main Aug 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants