Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ishermitian and opnorm requirement for custom operator types. #8

Open
MSeeker1340 opened this issue Oct 16, 2018 · 1 comment
Open
Assignees

Comments

@MSeeker1340
Copy link
Contributor

MSeeker1340 commented Oct 16, 2018

Currently to use a matrix-free operator we need to implement the LinearAlgebra.ishermitian and LinearAlgebra.opnorm (or provide a custom norm function). These slows down rapid prototyping and for some sparse types (e.g. SymTridiagonal) the default methods are not very efficient.

Since only scalar values are really needed, we should change the methods to not accept the functions themselves but their values with defaults (as suggested in #1).

For rapid prototyping & interfacing between packages, the end goal should be that only LinearAlgebra.mul! and Base.size needs to be implemented.

@MSeeker1340 MSeeker1340 self-assigned this Oct 16, 2018
@ChrisRackauckas
Copy link
Member

Instead of opnorm, could we use the norm of the vector from one application? That was mentioned in Jutho/KrylovKit.jl#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants