-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop publishing artifacts to Maven repository #658
Comments
additionally, we should automate building fat jar and adding it to release tab (we currently upload manually) |
How would this work? I assume we create releases manually, so we would need a workflow that takes release name as an input, creates a fat jar and uploads it to specified release. Or we also automate release creation, but not sure how would that work, since our releases have manually typed notes. |
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release Or just use release as trigger 😄 |
I meant automated fat jar creation and publishing the release. Even if with blank release notes. The notes could be edited later or taken as some input parameter (to be investigated if that's possible). Maybe something can automatically generate a "draft" for a release? Currently the problem is that when you generate the fat jar on your machine, you can do something differently each release, eg. mix up the java version, use a different branch rather than a tag etc. The idea is to let the machines do that, because they're better and don't make mistakes like I do. ;) |
I think we're using it (or something similar) to publish to mvn now. Couldn't that just build the fat jar for us? |
I assumed we publish on tags and commits to main, but yeah, I see we are triggering the publishing on releases instead of tags, we can use that. |
Users of Mesmer only need the fat jar generated by
sbt-assembly
, so we should not publish any artifacts to Maven repository.CI job for publishing and any code related to publishing should should be removed.
The text was updated successfully, but these errors were encountered: