Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify position-fixed behaviour #26

Open
AdaRoseCannon opened this issue Sep 28, 2020 · 1 comment
Open

Unify position-fixed behaviour #26

AdaRoseCannon opened this issue Sep 28, 2020 · 1 comment

Comments

@AdaRoseCannon
Copy link
Contributor

A bunch of elements have position:fixed and width:100% because they are position:fixed, width:100% isn't the parents width it's the page width.

There needs to be consistent width logic for the container which also gets applied to all position:fixed elements e.g.

  • Toast
  • Dialog
  • Tabs
@AdaRoseCannon
Copy link
Contributor Author

Perhaps a .fixed class for any element that is fixed that manages the size of fixed elements and uses the same logic and is in the same file as the container logic.

What do you think @lauramorinigo @PicchiKevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant