Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashing when setting trusted node #391

Closed
Moller40 opened this issue Feb 19, 2020 · 6 comments · May be fixed by #392
Closed

Crashing when setting trusted node #391

Moller40 opened this issue Feb 19, 2020 · 6 comments · May be fixed by #392

Comments

@Moller40
Copy link

Does not matter if it's a valid node or not. Can trigger the crash by setting this:

IP address: 111.111.111.111
Port: 8332
rpc user name: name
rpc user password: pass

02-19 11:32:12.772 18309 18922 E AndroidRuntime: FATAL EXCEPTION: Thread-9
02-19 11:32:12.772 18309 18922 E AndroidRuntime: Process: com.samourai.wallet, PID: 18309
02-19 11:32:12.772 18309 18922 E AndroidRuntime: java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/http/impl/client/DefaultHttpClient;
02-19 11:32:12.772 18309 18922 E AndroidRuntime: 	at com.samourai.wallet.JSONRPC.JSONRPC.doRPC(JSONRPC.java:255)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: 	at com.samourai.wallet.JSONRPC.JSONRPC.getNetworkInfoAsString(JSONRPC.java:220)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: 	at com.samourai.wallet.SettingsActivity2$42$1.run(SettingsActivity2.java:1178)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:919)
02-19 11:32:12.772 18309 18922 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: org.apache.http.impl.client.DefaultHttpClient
02-19 11:32:12.772 18309 18922 E AndroidRuntime: 	... 4 more
02-19 11:32:12.775  1749  9193 I am_crash: [18309,0,com.samourai.wallet,950550084,java.lang.ClassNotFoundException,org.apache.http.impl.client.DefaultHttpClient,JSONRPC.java,255]

Using Android 10. Maybe that triggers this problem?

Samourai version: 0.99.88
@Moller40
Copy link
Author

Think the solution is here: https://developer.android.com/about/versions/pie/android-9.0-changes-28#apache-p
Perhaps I do a PR.

@Moller40 Moller40 mentioned this issue Feb 24, 2020
Open
@pajasevi
Copy link
Contributor

Just FYI: setting a trusted node is now discouraged and this option should be removed in future release in favor of Dojo.

@davterra
Copy link

davterra commented Mar 2, 2020

I'm experiencing this issue as well.
What if I'm already running a full node and don't want to bother with Dojo? How can I connect my wallet?

@nicheosala
Copy link

I still cannot connect my Samourai Wallet 0.99.91 to my Bitcoin Core full node.
I go to Settings->Transactions->"Set trusted node". After entering the useful information, as soon as I click "ok", the app crashes.

@likewhoa
Copy link

likewhoa commented Apr 7, 2020

I still cannot connect my Samourai Wallet 0.99.91 to my Bitcoin Core full node.
I go to Settings->Transactions->"Set trusted node". After entering the useful information, as soon as I click "ok", the app crashes.

You shouldn't be doing this anymore as stated above this feature will be deprecated soon. The method is different now. You pair your wallet with your dojo instead. see https://github.com/Samourai-Wallet/samourai-dojo/blob/develop/doc/DOCKER_setup.md#pairing it's recommended to do this with a fresh wallet.

@Crazyk031
Copy link
Collaborator

Trusted node has been removed from the wallet, Dojo is the required backend for the wallet now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash when setting trusted node Moller40/samourai-wallet-android
6 participants
@likewhoa @pajasevi @davterra @Moller40 @nicheosala @Crazyk031