Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turborepo Readiness Validation #131

Open
9 of 10 tasks
ChakshuGautam opened this issue Jun 3, 2024 · 10 comments
Open
9 of 10 tasks

Turborepo Readiness Validation #131

ChakshuGautam opened this issue Jun 3, 2024 · 10 comments
Assignees

Comments

@ChakshuGautam
Copy link

ChakshuGautam commented Jun 3, 2024

  • Verify for all packages - when changed get rebuilt but the ones not changed should not be rebuilt | Cache should work. Measure build times.
  • Validate tree shaking inside molecules
  • Packages are resolved through local npm link as well as published link
    • Providers
    • Molecules
    • Custom Hooks
    • Localization
  • Readme.md is complete | Why Stencil?
  • RTL for single molecule
  • Storybook for some molecules
@ChakshuGautam ChakshuGautam changed the title Turborepo Readiness Turborepo Readiness Validation Jun 3, 2024
@biratdatta
Copy link
Collaborator

biratdatta commented Jun 5, 2024

image
When the cache is turned to be true, the dev server doesn't starts while
image
it is turned off , the server runs perfectly fine.

We need to debug this issue and we need to check if we can implement Remote Caching for further improvement in build speeds

@ChakshuGautam @prtkjakhar @ankitmlesmagico @thekavikumar

@ankitmlesmagico
Copy link
Collaborator

image
the issue is not regarding cache it is saying 3001 port allready in use
@biratdatta

@biratdatta
Copy link
Collaborator

image
@ankitmlesmagico can you recreate this on your PC with the "cache": true

@ankitmlesmagico
Copy link
Collaborator

ankitmlesmagico commented Jun 5, 2024

image
can you try again by taking a pull request
@biratdatta

@biratdatta
Copy link
Collaborator

#134 - Optimized Rollup for better tree shaking

@biratdatta
Copy link
Collaborator

#136 - PR for RTL

@thekavikumar
Copy link
Collaborator

#135 - Storybook for some molecules

@biratdatta
Copy link
Collaborator

biratdatta commented Jun 8, 2024

  • Caching is working now.
  • Checked the NPM Link and even with the Deployed NPM link that the packages are working.
  • written RTL for the launch pages as of now
  • I have also updated some rollup config so that it provides better redundant code removal and tree shaking
  • README needs to be done @biratdatta work in progress

@ChakshuGautam
Copy link
Author

@biratdatta please update the checklist in the first comment as well.

@biratdatta
Copy link
Collaborator

vercel/turborepo#8440 (comment) Cache getting missed problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants