-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed folders use old name (Offline Asset Removal does not work) #78
Comments
This script gets assets paths directly from the Immich API. So if the script doesn't pick up the new folder names, Immich does not provide them. |
Thanks for that; things make sense now. I rescanned the external library, waited a few hours until the logs were just doing facial detection stuff, then did a dry-run:
And the proposed album list is:
It's great that it's now detecting |
I thought maybe running the actual job would have the desired result, so I ran this command:
The resulting albums were the same:
|
I scanned the external library, waited 4-5 hours, checked to see there was nothing about it in the logs (no jobs running either), ran the "Library" job, let it complete, attempted to empty the trash (there was nothing there), and ran this dry-run command:
The result is the same:
What am I doing wrong? Does it matter that I'm also using the Immich Remove Offline Files script? I'm on Immich |
Actually I was thinking that this has to do with offline files. The way Immich handles offline files and its removal changed a couple of versions ago, not sure if the linked script still works as it should. But here's the good news: The Immich Folder Album Creator can do the same ;) The README section about dealing with external library changes linked above details how it works: By setting environment variable The script will log if there are any offline assets to remove and how many. Please make sure to check that output. |
Thanks for your reply. Just did that with a fake
Did the dry-run with this command:
Got the same result:
Did the dry-run with this command (no
Got this ✅:
I forgot that for all of the My question is: Since I changed the name from
Or am I misunderstanding something? |
That is indeed the question and not in line with what Immich should do. During my quick test yesterday I also was surprised that it did not detect these images as offline, which makes me think there might be a bug in Immich introduced in one of the latest version. But that requires more investigation before opening an issue with Immich itself (e.g. rolling back to an earlier version to see when/if the behavior changes). The change in dealing with offline assets was introduced with version 1.116.0. |
Did some more testing. |
Thanks for following up on this. Not much, but I also commented on an existing issue. |
I could really use some help on this, please.
For my
immich_server
container, the volume mapping for the external library is as follows:Based on
/ExtHDD/External-Libraries/Album1
, Immich Folder Album Creator made these albums:I then deleted all of the albums using the
DELETE_ALL
feature.On my Mac, I then renamed
/ExtHDD/External-Libraries/Album1
to/ExtHDD/External-Libraries/Album2
So when I run Immich Folder Album Creator, I expect to get:
However, when I do a dry-run, it says that the albums to be created are:
It's not picking up the new name, Album2.
The dry-run command I'm running is:
I also tried it with
--force-recreate
, but it didn't help. I also tried it with-e SYNC_MODE="2"
but it didn't help.Interestingly, if I run:
The albums listed are:
So if the
immich_server
container views the folder with the new name,Album2
, I'm not sure why Immich Folder Album Creator is still naming itAlbum1
.I also tried it on my other Mac, with a different Immich instance, but instead of deleting the albums I just renamed one folder and did a dry-run. Immich Folder Album Creator still uses the old folder name.
Any ideas why? I've tried several things: upgrading to the latest MacOS, clearing the Mac directory cache and restarting the Mac, deleting all Mac cache files and restarting the Mac, restarting the Docker daemon, restarting OrbStack, completely uninstalling then reinstalling OrbStack, and using Docker Desktop instead. But I get the same result.
I'd really appreciate any help. This is kind of driving me nuts. Thank you!
The text was updated successfully, but these errors were encountered: