Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portrait circles losing shape and de-centering content inside when compressed on a small screen #7140

Closed
1 task done
adamfsage opened this issue Dec 23, 2024 · 2 comments · Fixed by #7150
Closed
1 task done

Comments

@adamfsage
Copy link

Description

When portraits are compressed a little, I expect the content inside to remain in centre, and the shape to remain a circle. This particularly for portraits with text initials

Reproduction

https://carbon.sage.com/?path=/story/portrait--sizes&globals=viewport:xsm

Steps to reproduce

View Sizes story with extra small preview enabled

JIRA ticket numbers (Sage only)

SBS-117545

Suggested solution

I would like the option to override overflow property on portrait

Carbon version

146.2.1

Design tokens version

4.29.0

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@adamfsage adamfsage added Bug triage Triage Required labels Dec 23, 2024
@sianford sianford added On Backlog Squad Rivia and removed triage Triage Required labels Jan 7, 2025
@sianford
Copy link
Contributor

sianford commented Jan 7, 2025

FE-7039

tomdavies73 added a commit that referenced this issue Jan 9, 2025
portrait container now has a min-with, which prevents collapse on smaller screen sizes

fix #7140
tomdavies73 added a commit that referenced this issue Jan 13, 2025
portrait container now has a min-with, which prevents collapse on smaller screen sizes.
A max-width has also been added when an src path is passed to prevent image widths
significantly bypassing the new min-width

fix #7140
carbonci pushed a commit that referenced this issue Jan 17, 2025
### [146.4.4](v146.4.3...v146.4.4) (2025-01-17)

### Bug Fixes

* **portrait:** prevent portrait from collapsing on smaller screens ([dcafce2](dcafce2)), closes [#7140](#7140)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 146.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants