Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Troubleshoot Schematic failed tests reported by Andrew in main #2535

Closed
3 tasks done
tschaffter opened this issue Feb 27, 2024 · 4 comments
Closed
3 tasks done
Assignees
Labels
bug Something isn't working

Comments

@tschaffter
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What product(s) are you seeing the problem on?

Schematic

Current behavior

See this comment by @andrewelamb.

One question is why the errors reported where not detected in the last commit to main that modified Schematic.

Expected behavior

No response

Anything else?

No response

Commit ID

70f2f7b

Are you developing inside the dev container?

  • I am using the dev container

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tschaffter tschaffter added the bug Something isn't working label Feb 27, 2024
@andrewelamb
Copy link
Contributor

Ok so the problem is this.

The datamodel used for testing is part fo scchematic repo. In schematic v24.2.1, there were breaking changes to some methods and the data model. Updating to v24.2.1 will fix this as per this pr.

@andrewelamb
Copy link
Contributor

The reason there were no errors the last time the API was updated, was that the changes to the linked data model hadn't been pushed to main yet.

@andrewelamb
Copy link
Contributor

The short term fix is to get that PR merged into main. The long term fix is to link to a data model in its own repo, not part of schematic.

@tschaffter
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants