Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace readr with fread #372

Open
rrchai opened this issue Jul 21, 2022 · 0 comments
Open

Replace readr with fread #372

rrchai opened this issue Jul 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@rrchai
Copy link
Contributor

rrchai commented Jul 21, 2022

As developers of DCA, you probably have seen the below warning:

Warning: Setting row names on a tibble is deprecated.

The warning is coming from when we try to add rownames to tibble (default output data's type from readr::read_csv). The rownames is currently used to match the spreadsheet row index with preview table row index.

While we could avoid using rownames in tibble or find a solution to avoid ^ warning, we could just use fread instead to further improve the performance (ref):

  1. it is faster than readr
  2. it requires less memory usage

AC:
[ ] replace readrwith fread function to read csv
[ ] ensure that the way we use the row index in preview table or error message is behaved as before

@rrchai rrchai added the enhancement New feature or request label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants