Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to write arsc #5

Open
Xiangxingqian opened this issue Oct 21, 2020 · 5 comments
Open

Failed to write arsc #5

Xiangxingqian opened this issue Oct 21, 2020 · 5 comments

Comments

@Xiangxingqian
Copy link

Hi,
I am using axml to rewrite arsc file, and pxb.android.arsc.ArscWriter#main as entry, while it throws an exception, the input arsc can be found in attachment [attachment](url
resources.arsc.zip
)

Exception in thread "main" java.lang.RuntimeException
	at pxb.android.arsc.ArscParser.readPackage(ArscParser.java:256)
	at pxb.android.arsc.ArscParser.parse(ArscParser.java:142)
	at pxb.android.arsc.ArscWriter.main(ArscWriter.java:95)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

Is there any idea why this happens?

Looking forward your reply, thank you.

@YaxinCheng
Copy link

This process failed at the read/parse part, and I have opened a PR to fix it: #9

I am not sure if the writer part works or not, but this should at least give you a different error

@rushiiMachine
Copy link

Since this lib appears to be dead, we have forked it and made our changes here

@StevenArzt
Copy link
Member

@DiamondMiner88 axml is not dead. There's just not much happening, since it's a small library, most bugs have long been sorted out, and the use case is too small to have many new features. If you have improvements, please open a pull request. Btw, we did a new release in August with bugfixes...

@rushiiMachine
Copy link

Well, #12 hasn't been fully fixed like Ven said

@StevenArzt
Copy link
Member

He closed his own merge request, so I can't merge that. Further, nobody provided a proper example why my fix for #12 isn't sufficient. I might have missed something, that's all fine, but then please provide a proper explanation of what the problem still is, or - even better - open a merge request and propose a proper fix.

We're running mass analyses including instrumentation with lots of APK writing and reading for paper evaluations in my lab, and we don't see things breaking left and right. That doesn't mean that no bug is possible, but if there was something breaking left and right, we would have fixed it already. If there is a corner case that you can reproduce, please contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants