-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have a bunch of contributions to make #20
Comments
Here's the diff: |
We warmly welcome your contribution. Here is some comment/context I want to share with you.
Most of test code is Thank you very much for your comment. You can open a PR at any time |
Hi, I had cleared the code:
I have to admit, this project is very complex. Some helpful tips: Dev setupRef to docs
pip install hatch hatch-nodejs-version pytest pytest_jupyter ruff
npm install -g pnpm
git clone https://github.com/SUSTech-data/neopyter
cd neopyter
pnpm install
# which will install additional tool for dev mode
pip install -e ".[dev]"
in this mode, you can modify the Neopyter async context
If you have any questions, feel free to comment at any time |
@AbaoFromCUG I'm writing this issue to let you know that I have a few features that I'd like to contribute. I've already implemented everything I'm about to describe.
I'll do my best to split these features into different PRs, but inevitably some changes are going to stack on top of each other. Here's a list of what to expect in the next few days/weeks:
'commentstring'
instead of hard coded#
:Neopyter console
command that opens a split console to the same kernel that's running in Jupyter Lab. This usesjupyter-kernel
under the hood, tmux and nvim terminal are supported. In the case that tmux is used, setup the appropriate buffer local variables to allow vim-slime to just workAlong with these changes comes a large documentation overhaul, and I've touched nearly every file in the codebase. Sorry I'm dumping all of this on you at once, if I could have, I would have contributed as this stuff was implemented.
Is there anything in this list you don't want me to contribute?
I will probably wait to split things up until you've commented. I will put up a branch shortly that has all of these changes rolled together if you're curious.
Also as you might imagine, this stuff breaks a lot of tests. I didn't write any tests myself. But I can add them before opening PRs, it will just slow down the rate of PRs a good bit
The text was updated successfully, but these errors were encountered: