Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEMH-60, CHEMH-61: Section background colors #93

Merged
merged 10 commits into from
May 1, 2024

Conversation

jenbreese
Copy link
Collaborator

@jenbreese jenbreese commented Apr 22, 2024

READY FOR REVIEW

Summary

  • Adding a dark grey and a light grey section background.

Review By (Date)

  • time allows

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Create a basic page and use the background colors and the padding.
  4. Add examples of all the elements to see they work on the dark grey background in particular.
  5. Verify there aren't any missing components for the dark background.
  6. Verify the padding works.
  7. The logic was resused from the IRSR work.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- CHEMH-60
- CHEMH-61

Resources

@jenbreese jenbreese changed the title Chemh 60 row bg colors Chemh-60, CHEMH-61: Section background colors Apr 23, 2024
@jenbreese jenbreese changed the title Chemh-60, CHEMH-61: Section background colors CHEMH-60, CHEMH-61: Section background colors Apr 23, 2024
@github-actions github-actions bot added size/m and removed size/s labels Apr 26, 2024
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jenbreese!

@jenbreese jenbreese merged commit b672311 into 2.x May 1, 2024
1 check passed
@jenbreese jenbreese deleted the CHEMH-60--row-bg-colors branch May 1, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants