Fix: Accessing member of deleted objects

scuzqy · opcm · commit b154402e1358 · 2024-02-25T14:54:39.000+01:00
diff --git a/src/windows/windriver.h b/src/windows/windriver.h
@@ -107,7 +107,8 @@ class Driver
                 if (err == ERROR_SERVICE_ALREADY_RUNNING) return true;
 
                 std::wcerr << "Starting MSR service failed with error " << err << " ";
-                const TCHAR * errorStr = _com_error(err).ErrorMessage();
+                const _com_error comError{ (int)err };
+                const TCHAR * errorStr = comError.ErrorMessage();
                 if (errorStr)
                     std::wcerr << errorStr << "\n";
 
@@ -120,7 +121,8 @@ class Driver
             else
             {
                 std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";
-                const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();
+                const _com_error comError{ (int)GetLastError() };
+                const TCHAR * errorStr = comError.ErrorMessage();
                 if (errorStr)
                     std::wcerr << errorStr << "\n";
             }
@@ -130,7 +132,8 @@ class Driver
         else
         {
             std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";
-            const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();
+            const _com_error comError{ (int)GetLastError() };
+            const TCHAR * errorStr = comError.ErrorMessage();
             if (errorStr)
                 std::wcerr << errorStr << "\n";
         }
@@ -169,7 +172,8 @@ class Driver
         else
         {
             std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";
-            const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();
+            const _com_error comError{ (int)GetLastError() };
+            const TCHAR * errorStr = comError.ErrorMessage();
             if (errorStr)
                 std::wcerr << errorStr;
         }
@@ -197,7 +201,8 @@ class Driver
         else
         {
             std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";
-            const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();
+            const _com_error comError{ (int)GetLastError() };
+            const TCHAR * errorStr = comError.ErrorMessage();
             if (errorStr)
                 std::wcerr << errorStr;
         }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,8 @@ class Driver`
`107`	`107`	`if (err == ERROR_SERVICE_ALREADY_RUNNING) return true;`
`108`	`108`
`109`	`109`	`std::wcerr << "Starting MSR service failed with error " << err << " ";`
`110`		`- const TCHAR * errorStr = _com_error(err).ErrorMessage();`
	`110`	`+ const _com_error comError{ (int)err };`
	`111`	`+ const TCHAR * errorStr = comError.ErrorMessage();`
`111`	`112`	`if (errorStr)`
`112`	`113`	`std::wcerr << errorStr << "\n";`
`113`	`114`
`@@ -120,7 +121,8 @@ class Driver`
`120`	`121`	`else`
`121`	`122`	`{`
`122`	`123`	`std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";`
`123`		`- const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();`
	`124`	`+ const _com_error comError{ (int)GetLastError() };`
	`125`	`+ const TCHAR * errorStr = comError.ErrorMessage();`
`124`	`126`	`if (errorStr)`
`125`	`127`	`std::wcerr << errorStr << "\n";`
`126`	`128`	`}`
`@@ -130,7 +132,8 @@ class Driver`
`130`	`132`	`else`
`131`	`133`	`{`
`132`	`134`	`std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";`
`133`		`- const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();`
	`135`	`+ const _com_error comError{ (int)GetLastError() };`
	`136`	`+ const TCHAR * errorStr = comError.ErrorMessage();`
`134`	`137`	`if (errorStr)`
`135`	`138`	`std::wcerr << errorStr << "\n";`
`136`	`139`	`}`
`@@ -169,7 +172,8 @@ class Driver`
`169`	`172`	`else`
`170`	`173`	`{`
`171`	`174`	`std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";`
`172`		`- const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();`
	`175`	`+ const _com_error comError{ (int)GetLastError() };`
	`176`	`+ const TCHAR * errorStr = comError.ErrorMessage();`
`173`	`177`	`if (errorStr)`
`174`	`178`	`std::wcerr << errorStr;`
`175`	`179`	`}`
`@@ -197,7 +201,8 @@ class Driver`
`197`	`201`	`else`
`198`	`202`	`{`
`199`	`203`	`std::wcerr << "Opening service manager failed with error " << GetLastError() << " ";`
`200`		`- const TCHAR * errorStr = _com_error(GetLastError()).ErrorMessage();`
	`204`	`+ const _com_error comError{ (int)GetLastError() };`
	`205`	`+ const TCHAR * errorStr = comError.ErrorMessage();`
`201`	`206`	`if (errorStr)`
`202`	`207`	`std::wcerr << errorStr;`
`203`	`208`	`}`