Remove extraneous 'import pickle' statements #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, a few except handlers in Bot.py specific to pickle
double-fault
reviewed
Aug 5, 2019
There was a problem hiding this comment.
LGTM. Has this been tested? That is, have you tried installing the changes locally and verified whether a sample bot runs successfully on it?
I don't think a new release will be necessary since some extra code is quite harmless; still, feel free to make one if you'd like to.
|
Yeah, the simple example script works fine at least. Unsure what exactly could still use |
double-fault
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #31
Also, a few except handlers in Bot.py specific to
pickle-- I have assumed that there is nothing injsonpicklewhich could cause these, and that they simply were left around from an earlier version of the code, but please review this particular assumption.