Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent use of pointer vs reference_wrapper #126

Open
jacobmerson opened this issue Mar 6, 2023 · 0 comments
Open

Consistent use of pointer vs reference_wrapper #126

jacobmerson opened this issue Mar 6, 2023 · 0 comments

Comments

@jacobmerson
Copy link
Collaborator

using ptr in some places and reference wrapper in others makes for a clunky interface that's inconsistent in some places. Reference wrapper was used to imply that in those places, the pointers should not be null.

However, it's not clear that these semantics are worth the extra effort that's needed to convert the ptrs into reference wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant