Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider]: Slider value cannot be committed via keyboard handling #10770

Open
1 task done
mhjzhang opened this issue Feb 5, 2025 · 1 comment · May be fixed by #10803
Open
1 task done

[Slider]: Slider value cannot be committed via keyboard handling #10770

mhjzhang opened this issue Feb 5, 2025 · 1 comment · May be fixed by #10803
Assignees
Labels
bug This issue is a bug in the code consulting Medium Prio TOPIC RL

Comments

@mhjzhang
Copy link

mhjzhang commented Feb 5, 2025

Bug Description

Changing the slider value using the keyboard only fires the input event, never the change event. According to the documentation, the input event is fired on user interaction that has not yet finished, while the change event is fired when interaction with the slider is finished, so there's currently no way to indicate that interaction is finished after making changes with the keyboard.

Affected Component

Slider

Expected Behaviour

There should be keys that fire the change event, such as space or enter.

Isolated Example

https://sap.github.io/ui5-webcomponents/components/Slider/

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

V1, V2

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@NHristov-sap
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl ,

Please check and consult/fix the reportred issue.

Best Regards,
Nikolay Hristov

@ndeshev ndeshev self-assigned this Feb 5, 2025
@mhjzhang mhjzhang changed the title [Slider/RangeSlider]: Slider value cannot be committed via keyboard handling [Slider]: Slider value cannot be committed via keyboard handling Feb 6, 2025
@ndeshev ndeshev moved this from New Issues to In progress in Maintenance - Topic RL Feb 10, 2025
ndeshev added a commit that referenced this issue Feb 10, 2025
@ndeshev ndeshev linked a pull request Feb 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code consulting Medium Prio TOPIC RL
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants