Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-side-navigation]: inappropriate exclamation mark usage #10714

Open
1 task done
nnaydenow opened this issue Jan 30, 2025 · 0 comments · May be fixed by #10769
Open
1 task done

[ui5-side-navigation]: inappropriate exclamation mark usage #10714

nnaydenow opened this issue Jan 30, 2025 · 0 comments · May be fixed by #10769
Assignees
@LidiyaGeorgieva
Labels
bug This issue is a bug in the code TOPIC RD

Comments

@nnaydenow
Copy link
Contributor

Bug Description

https://github.com/SAP/ui5-webcomponents/blob/main/packages/fiori/src/SideNavigation.ts#L496

getDomRef could return undefined when it's called on element that still doesn't have shadow DOM content.

There is no clear contract that says the child components will have DOM ref.

This should be revised and refactor.

Affected Component

ui5-side-navigation

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nnaydenow nnaydenow added bug This issue is a bug in the code TOPIC RD labels Jan 30, 2025
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Jan 31, 2025
LidiyaGeorgieva added a commit that referenced this issue Feb 4, 2025
@LidiyaGeorgieva
fix(ui5-side-navigation): "Space" key triggers links
a26b1ae 
Pressing "Space" key triggers click on the items with external links.
In addition inappropriate exclamation mark usage removed.

fixes: #10654
fixes: #10714
@LidiyaGeorgieva LidiyaGeorgieva mentioned this issue Feb 4, 2025
Open
LidiyaGeorgieva added a commit that referenced this issue Feb 4, 2025
@LidiyaGeorgieva
fix(ui5-side-navigation): remove inappropriate exclamation mark usage
8624af0 
fixes: #10714
@LidiyaGeorgieva LidiyaGeorgieva linked a pull request Feb 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LidiyaGeorgieva LidiyaGeorgieva

Labels
bug This issue is a bug in the code TOPIC RD
Projects
Maintenance - Topic RD
Status: New Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-side-navigation): remove inappropriate exclamation mark usage SAP/ui5-webcomponents
2 participants
@LidiyaGeorgieva @nnaydenow