Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_objIsLinear() is inefficient #1

Open
SALZKARTOFFEEEL opened this issue Mar 24, 2019 · 0 comments
Open

_objIsLinear() is inefficient #1

SALZKARTOFFEEEL opened this issue Mar 24, 2019 · 0 comments
Labels
code quality Concerning the quality of the code

Comments

@SALZKARTOFFEEEL
Copy link
Owner

SALZKARTOFFEEEL commented Mar 24, 2019 •
edited
Loading

The utility function _objIsLinear() could probably be made more efficient by doing some fancy business with obj.count() and other object methods.
The current function works well for small objects, but takes a bit of time for bigger ones.
It is O(n) in the worst case (not too bad), but could potentially be made O(1).
@SALZKARTOFFEEEL SALZKARTOFFEEEL added the code quality Concerning the quality of the code label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Concerning the quality of the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SALZKARTOFFEEEL