public keyword for variants

[Roger-luo]

Currently, we mark all variants in the namespace as public in 1.11+. Because if the GADT module is being marked public what's inside the module should be treated as public, because they are as a whole. But maybe there would be use case only part of the variants are public?

Please comment on this issue so we can collect such a use case.

[nandoconde]

Just to add info to the conversation, in Rust all variants are made public by default when the Enum is made public:

In contrast, if we make an enum public, all of its variants are then public.

Enums aren’t very useful unless their variants are public; it would be annoying to have to annotate all enum variants with pub in every case, so the default for enum variants is to be public.

Source: https://doc.rust-lang.org/book/ch07-03-paths-for-referring-to-an-item-in-the-module-tree.html#making-structs-and-enums-public

[Roger-luo]

I see. This makes sense, then I did the right thing without thinking it I guess lol