Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi select #1282

Closed
wants to merge 2 commits into from
Closed

fix: multi select #1282

wants to merge 2 commits into from

Conversation

SySagar
Copy link

@SySagar SySagar commented Feb 4, 2024

fix(multi select): Collapse and scroll on open fixed

Proposed changes (including videos or screenshots)

  • added a state variable to control visibility
  • stopped the scrolling of select on open state

Issue(s)

Closes #1281
Closes #1284

Copy link

changeset-bot bot commented Feb 4, 2024

⚠️ No Changeset found

Latest commit: ab56c61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Spiral-Memory
Copy link

@SySagar , could you please explain what you mean by the collapse issue you mentioned? I believe there is already a pull request raised at #1265 for that particular issue. Please check it out and see if it addresses the same problem you have resolved here.

@SySagar
Copy link
Author

SySagar commented Feb 5, 2024

Yes I check the pr earlier but it resolves only the collapse not the scrolling part
In my pr both my the problems addressed are resolved

@Spiral-Memory
Copy link

@SySagar Yeah, that's good. Now, you can focus on the scrolling issue only, as the other problem has already been addressed. Having multiple PRs solving the same issue will result in confusion. You can remove that commit and force push.

@SySagar
Copy link
Author

SySagar commented Feb 5, 2024

Wouldn’t it be good if this pr closes both or I can update the other pr don’t know if that is possible

@Spiral-Memory
Copy link

@SySagar , but that has already been addressed, right? There has been effort put into solving the issue. Having multiple PRs solving the same issue may waste others' efforts.

@SySagar
Copy link
Author

SySagar commented Feb 5, 2024

No worried I will force push this will that be ok?or should I update that pr of other person

@Spiral-Memory
Copy link

Spiral-Memory commented Feb 5, 2024

No worried I will force push this will that be ok?

Yeah sure. Thank you for your understanding, You can also update your issue solving the scroll issue.

@Spiral-Memory
Copy link

No worried I will force push this will that be ok?or should I update that pr of other person

You won't be able to edit PR of other person. So you can go with removing the second commit and force push.

@dougfabris
Copy link
Member

Hi there, thanks for the contribution! 🚀 💯

We're planning an entire replacement of all the components related to AutoComplete and all the Select components since we're focusing a lot on accessibility. Trying to maintain it became a nightmare, and because of that we're not going to accept any contributions related to these components at this time.


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiselect: close button not working MultiFiltered Select
4 participants