Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keyboard shortcuts with alt keys in message composer #34181

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: keyboard shortcuts with alt keys in message composer #34181

wants to merge 2 commits into from
+15 −11

Conversation

Kartikayy007
Copy link

@Kartikayy007 Kartikayy007 commented Dec 15, 2024 •
edited
Loading

Proposed changes

Fixed keyboard shortcuts behavior in message composer:

  • Alt + Up Arrow now correctly moves cursor to start
  • Alt + Down Arrow now correctly moves cursor to end
  • Separated navigation logic from Alt key handling

Issue(s)

Fixes #34178

Steps to test or reproduce

  1. Open any chat room
  2. Click message composer
  3. Test following shortcuts:
    • Press Alt + Up Arrow -> Cursor should move to start
    • Press Alt + Down Arrow -> Cursor should move to end
    • Press Up Arrow without Alt at start -> Should navigate to previous message
    • Press Down Arrow without Alt at end -> Should navigate to next message

Technical Implementation

Changed keyboard event handling in MessageBox.tsx to properly manage event propagation and cursor positioning.

@Kartikayy007 Kartikayy007 requested a review from a team as a code owner December 15, 2024 13:25
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eadefb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Kartikayy007 Kartikayy007 mentioned this pull request Dec 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Keyboard shortcuts are not working
1 participant
@Kartikayy007